Use 64 bits for time_t #17401
Merged
Use 64 bits for time_t #17401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Jul 8, 2022
sbc100
force-pushed
the
restore_64bit_time_t
branch
from
15da934 to
cd78df6
Compare
sbc100
changed the title
sbc100
force-pushed
the
restore_64bit_time_t
branch
from
cd78df6 to
c0b6ba6
Compare
This brings us back in line with upstream musl. The change to 32-bit was only recently made in #16966. The reason we made this change was made was because we had certain C library calls that were implemented in JS that returned `time_t`. Since returning 64-bit values from JS functions is not always easy (we don't always have WASM_BIGINT available) that simplest solution was to define `time_t` to 32-bit which doesn't have issues at the JS boundary. However, in the intervening time many of the `time_t`-returning function have been moved into native code (See #16606 and #16439) with only two remaining: _mktime_js and _timegm_js. So this change redefines just those two functions to return `int` while keeping `time_t` itself as 64-bit. Fixes: #17393
sbc100
force-pushed
the
restore_64bit_time_t
branch
from
c0b6ba6 to
8ae0b3e
Compare
kripken
reviewed
Jul 8, 2022
kripken
approved these changes
Jul 8, 2022
Co-authored-by: Alon Zakai <[email protected]>
|
Thanks! |
xbcnn
pushed a commit
to xbcnn/emscripten
that referenced
this pull request
Jul 22, 2022
This brings us back in line with upstream musl. The change to 32-bit was only recently made in emscripten-core#16966. The reason we made this change was made was because we had certain C library calls that were implemented in JS that returned `time_t`. Since returning 64-bit values from JS functions is not always easy (we don't always have WASM_BIGINT available) that simplest solution was to define `time_t` to 32-bit which doesn't have issues at the JS boundary. However, in the intervening time many of the `time_t`-returning function have been moved into native code (See emscripten-core#16606 and emscripten-core#16439) with only two remaining: _mktime_js and _timegm_js. So this change redefines just those two functions to return `int` while keeping `time_t` itself as 64-bit. Fixes: emscripten-core#17393
This was referenced Jul 20, 2023
hoodmane
added a commit
to hoodmane/libc
that referenced
this pull request
Jan 30, 2024
hoodmane
added a commit
to hoodmane/libc
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us back in line with upstream musl. The change to 32-bit
was only recently made in #16966. The reason we made this change was
made was because we had certain C library calls that were implemented in
JS that returned
time_t. Since returning 64-bit values from JSfunctions is not always easy (we don't always have WASM_BIGINT
available) that simplest solution was to define
time_tto 32-bit whichdoesn't have issues at the JS boundary.
However, in the intervening time many of the
time_t-returning functionhave been moved into native code (See #16606 and #16439) with only two
remaining: _mktime_js and _timegm_js. So this change redefines just
those two functions to return
intwhile keepingtime_titself as64-bit.
Fixes: #17393